Conversation
|
GreenX is not available on Spack, but it looks like a solid project that should be easy to add. Once this PR is merged, I'll add it to Spack and then in CI (Spack + CMake). |
tests/TEST_DIRS
Outdated
| # the order will be regularly checked and modified... | ||
| QS/regtest-double-hybrid-stress-laplace libint libxc | ||
| QS/regtest-rpa-sigma libint | ||
| QS/regtest-rpa-sigma libint greenx=.false. |
There was a problem hiding this comment.
The correct syntax here would be !greenx, but we currently only use it for leak sanitizer and I don't think we should start using it for features.
I think, an input file should either produce the same result regardless of the presents of a library or fail if the required library is missing.
So, if GreenX produces significantly different results then it's essentially a different method and therefore merits an input keyword to enable/disable it.
There was a problem hiding this comment.
Hi Ole, I see your point and I was thinking about this, too. For a few cases, greenX and the internal minimax have slightly different grids. Because of numerical instabilities, this affects the results, but only for small grids. For those, I relaxed either the tolerance a little or I used a larger, numerically more stable grids. I can fix the "regtest-rpa-sigma" tests in a similar manner; I have to admit I was a little lazy here. The other case "QS/regtest-gw-kpoints" I would leave because the tests are already relatively long and a larger grids makes them even longer...
There was a problem hiding this comment.
Sounds like well balanced plan 👍
I'd suggest we use !greenx only for the transition period and once we have GreenX in the toolchain we change the reference values and switch to greenx (without the !).
|
The recent PRs have unfortunately created some merge conflict. Once those are resolved this seems ready to be merged. |
…ince grids are used which are not in greenx
…in integration weights for large grids
…t and add regularization
…ed (small minimax grids different between greenx and internal routines)
…nx runs (toml files)
Contains the interface to the minimax and analytic continuation component of the greenX library.