Skip to content

Allegro: Fix parallelization with virials#3445

Merged
fstein93 merged 4 commits intocp2k:masterfrom
mariabilichenk0:master
Jun 5, 2024
Merged

Allegro: Fix parallelization with virials#3445
fstein93 merged 4 commits intocp2k:masterfrom
mariabilichenk0:master

Conversation

@mariabilichenk0
Copy link
Contributor

No description provided.

@oschuett
Copy link
Member

The tests failed because allegro/nequip is taking too long. Ideally each test input should run in less than 10 seconds. This is something we also noticed on the dashboard.

Could you speed them up somehow? Is see that you are already doing just a single MD step. So maybe we need to make the system smaller, e.g. use only 16 water molecules.

@fstein93
Copy link
Contributor

fstein93 commented Jun 1, 2024

Is the fix I added in #3434 erroneous?

@mariabilichenk0
Copy link
Contributor Author

Is the fix I added in #3434 erroneous?

I checked stress with 1 and 4 cores (both Allegro and NequIP) and I get the same result, so I think all is good there 😊

@mariabilichenk0
Copy link
Contributor Author

Could you speed them up somehow? Is see that you are already doing just a single MD step. So maybe we need to make the system smaller, e.g. use only 16 water molecules.

I have reduced all the models to 1 layer along with reducing few other training parameters, which makes the models not suitable for production runs but speeds up the tests. From regtest-allegro/ I have removed water-gra-film-sp.inp and left only water-bulk-sp.inp since they are using the same model, but the later one is faster. From regtest-nequip/ I removed water-bulk-dp.inp energy test case and left only stress test case since they share the input. This has improved the timings overall for both sdbg and pdbg. As for the system size, it took 14sec for a single water molecule and 19sec for 32 waters, so halving the system size, unfortunately, does not make it much faster. Thank you for the suggestions 😊

@fstein93 fstein93 merged commit 3a64028 into cp2k:master Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants