Skip to content

Adjust tolerance.#14

Merged
oschuett merged 1 commit intocp2k:masterfrom
oschuett:adjust_tolerance
Oct 4, 2018
Merged

Adjust tolerance.#14
oschuett merged 1 commit intocp2k:masterfrom
oschuett:adjust_tolerance

Conversation

@oschuett
Copy link
Member

@oschuett oschuett commented Oct 3, 2018

No description provided.

@dev-zero
Copy link
Contributor

dev-zero commented Oct 4, 2018

Can you please add a comment on which arch/platform/compiler the current tolerance failed?

@oschuett
Copy link
Member Author

oschuett commented Oct 4, 2018

The h2o_ot_precond_7.inp failed here:
https://dashboard.cp2k.org/archive/current-ssmp/commit_3fbbec4104122a0d4063128c6620913ae359cc4f.txt.
The other two failed on Swan, but I can't find it back. It probably disappeared. I'll remove it for the time beeing.

@alazzaro
Copy link
Member

alazzaro commented Oct 4, 2018

Yeap, on Swan it was a small glitch... By re-executing the job the problem disappeared... Anyway, the new tolerances are more stable...

@oschuett
Copy link
Member Author

oschuett commented Oct 4, 2018

Well if you only re-executed then the glitch will likely reappear. So, I'm putting those back in.

@alazzaro
Copy link
Member

alazzaro commented Oct 4, 2018

Well if you only re-executed then the glitch will likely reappear. So, I'm putting those back in.

Indeed, that's what I meant with "new tolerances are more stable".

@oschuett oschuett merged commit 6dcbc07 into cp2k:master Oct 4, 2018
@dev-zero
Copy link
Contributor

dev-zero commented Oct 4, 2018

@oschuett what I meant: add the comment inside the commit message such that people who do a git log get a bit more information other than the obvious "adjusted tolerance"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants