Skip to content

Conversation

@kvaps
Copy link
Member

@kvaps kvaps commented Jan 16, 2026

Summary

  • Replace manual HelmRelease manifest with simple bundle-enable: nfs-driver configuration option
  • Add note about waiting for platform chart reconciliation

Test plan

  • Verify documentation renders correctly

Summary by CodeRabbit

  • Documentation
    • Updated NFS storage setup guide with simplified driver enablement process via configuration directive
    • Refined verification steps using kubectl commands for HelmRelease status
    • Enhanced NFS export configuration instructions with expanded setup details and clarity on reconciliation workflow

✏️ Tip: You can customize this high-level summary in your review settings.

Replace manual HelmRelease manifest with simple bundle-enable option.
Add note about waiting for platform chart reconciliation.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@netlify
Copy link

netlify bot commented Jan 16, 2026

Deploy Preview for cozystack ready!

Name Link
🔨 Latest commit 7096616
🔍 Latest deploy log https://app.netlify.com/projects/cozystack/deploys/696a1f5974e0dd00087036b5
😎 Deploy Preview https://deploy-preview-399--cozystack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Documentation update to the NFS storage setup guide that removes embedded Kubernetes YAML resources and replaces them with Cozystack configuration directives, streamlines verification steps, and adds practical NFS export share setup instructions.

Changes

Cohort / File(s) Summary
NFS Storage Documentation
content/en/docs/storage/nfs.md
Section header renamed from "Driver and provisioner setup" to "Enable NFS driver"; embedded Namespace and HelmRelease YAML resources removed and replaced with Cozystack bundle-enable directive; finalization workflow changed from local build execution (cd, make apply) to reconciliation waiting with kubectl verification; new "Export share" section added with NFS server installation and configuration commands; narrative flow adjusted from resource declaration to configuration-based setup with practical export details.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 The docs have found simplicity's way,
Removing YAML clutter from the day,
Configuration directives now lead the dance,
While export shares get their rightful chance,
Clarity blooms where complexity lay. 🌱



📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9fa8506 and 7096616.

📒 Files selected for processing (1)
  • content/en/docs/storage/nfs.md

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kvaps, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refines the documentation for setting up the NFS driver by simplifying the configuration process. It transitions from a verbose, manual HelmRelease manifest to a more declarative bundle-enable option, making the setup more straightforward and less prone to errors. The changes aim to enhance user experience by providing clearer, more concise instructions for enabling the NFS driver.

Highlights

  • Simplified NFS Driver Setup: The documentation now guides users to enable the NFS driver using a concise bundle-enable: nfs-driver configuration option, replacing a lengthy manual HelmRelease manifest.
  • Streamlined Verification Process: The instructions for applying the configuration have been updated from a make apply command to a kubectl get helmrelease command, focusing on verifying the successful creation of the HelmRelease.
  • Improved Clarity for Reconciliation: A new note has been added, advising users to wait for the platform chart to reconcile after applying the configuration, ensuring a smoother setup experience.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kvaps kvaps marked this pull request as ready for review January 16, 2026 11:22
@kvaps kvaps merged commit 2586dc1 into main Jan 16, 2026
6 checks passed
@kvaps kvaps deleted the docs/simplify-nfs-driver-setup branch January 16, 2026 11:22
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the documentation for setting up the NFS driver by replacing a manual HelmRelease manifest with a bundle-enable configuration option. The changes make the process much more straightforward for users. My feedback focuses on improving the clarity of the new instructions to ensure users can easily locate and update their Cozystack configuration.

Comment on lines +12 to 16
Add `bundle-enable: nfs-driver` to your Cozystack configuration:

```yaml
---
apiVersion: v1
kind: Namespace
metadata:
labels:
cozystack.io/system: "true"
pod-security.kubernetes.io/enforce: privileged
name: cozy-nfs-driver
spec:
finalizers:
- kubernetes
---
apiVersion: helm.toolkit.fluxcd.io/v2
kind: HelmRelease
metadata:
labels:
cozystack.io/repository: system
cozystack.io/system-app: "true"
name: nfs-driver
namespace: cozy-nfs-driver
spec:
chart:
spec:
chart: cozy-nfs-driver
reconcileStrategy: Revision
sourceRef:
kind: HelmRepository
name: cozystack-system
namespace: cozy-system
version: '>= 0.0.0-0'
dependsOn:
- name: cilium
namespace: cozy-cilium
- name: kubeovn
namespace: cozy-kubeovn
install:
crds: CreateReplace
remediation:
retries: -1
interval: 5m
releaseName: nfs-driver
suspend: true
upgrade:
crds: CreateReplace
remediation:
retries: -1
bundle-enable: nfs-driver
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The instruction to add bundle-enable: nfs-driver to the Cozystack configuration is a great simplification. However, it might be unclear for some users exactly where this configuration should be added. To improve clarity, could you please provide a more complete example showing this line within its parent configuration structure, or at least mention the name of the configuration file and the section where this should be added? This will help users apply the configuration correctly without guesswork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants