Skip to content

[0.39][paas-full] Add multus dependencies similar to other CNIs #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kvaps merged 1 commit into from
Jan 9, 2026
Merged

[0.39][paas-full] Add multus dependencies similar to other CNIs #1835

kvaps merged 1 commit into from
Jan 9, 2026

Conversation

@nbykov0
Copy link
Collaborator

@nbykov0 nbykov0 commented Jan 8, 2026

What this PR does

Adds multus as a dependency as other CNIs

Release note

Adds multus as a dependency as other CNIs

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 8, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 8, 2026

Summary of Changes

Hello @nbykov0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates Multus CNI into the paas-full bundle by updating the dependency configurations for a wide array of platform components. This ensures that Multus is properly recognized and initialized before dependent services, aligning its treatment with other core Container Network Interfaces.

Highlights

  • Multus CNI Integration: Multus CNI has been integrated as a core dependency across numerous components within the paas-full bundle, ensuring its proper initialization and availability for dependent services.
  • Dependency Updates: The dependsOn lists for various releases, including cozystack, cert-manager-crds, cozystack-api, kubevirt, and many operators (e.g., victoria-metrics-operator, mariadb-operator), have been updated to explicitly include multus.
  • Minor Formatting Correction: A minor formatting adjustment was made in the dependsOn list for the monitoring-agents release, removing an unnecessary space.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@nbykov0 nbykov0 self-assigned this Jan 8, 2026
@nbykov0 nbykov0 added the backport Should change be backported on previus release label Jan 8, 2026
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 8, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds multus as a dependency to various releases in the paas-full.yaml bundle. The changes are mostly correct and achieve the stated goal. However, I've identified a critical syntax error in one of the dependsOn lists that will likely cause parsing issues. I've also commented on a minor, unrelated style change and recommended adopting a consistent formatting style for YAML lists to improve readability and maintainability.

@nbykov0 nbykov0 force-pushed the multus-deps-0.39 branch 2 times, most recently from 54a1dc8 to 527c49c Compare January 9, 2026 16:27
@nbykov0 nbykov0 changed the title [0.39][paas-full] Add multus dependency as other CNIs [0.39][paas-full] Add multus dependencies similar to other CNIs Jan 9, 2026
@nbykov0 nbykov0 removed the backport Should change be backported on previus release label Jan 9, 2026
@nbykov0
[paas-full] Add multus dependency as other CNIs
ce6ec2c 
Signed-off-by: nbykov0 <166552198+nbykov0@users.noreply.github.com>
@nbykov0 nbykov0 marked this pull request as ready for review January 9, 2026 17:04
@nbykov0 nbykov0 requested review from kvaps and lllamnyp as code owners January 9, 2026 17:05
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jan 9, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 9, 2026
@kvaps kvaps merged commit 98cab21 into release-0.39 Jan 9, 2026
26 checks passed
@kvaps kvaps deleted the multus-deps-0.39 branch January 9, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvaps kvaps kvaps approved these changes

@lllamnyp lllamnyp Awaiting requested review from lllamnyp lllamnyp is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nbykov0 nbykov0

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nbykov0 @kvaps