[ci,dx] Bump MariaDB operator version #1646
Conversation
Update MariaDB operator to a new version. ```release-note [ci,dx] Update MariaDB operator version ``` Signed-off-by: IvanHunters <xorokhotnikov@gmail.com>
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughChart metadata and defaults for the MariaDB Operator were bumped from 0.38.1 → 25.10.2, MariaDB image defaults updated to 11.8, RBAC rules expanded (endpoints → endpointslices, volumesnapshots, persistentvolumeclaim delete, new custom resources), MutatingWebhook removed and new Validating webhook added for physicalbackups. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant K8s as Kubernetes API
participant Webhook as Admission Webhooks
participant Operator as MariaDB Operator
note right of Webhook `#bfe3c9`: Mutating webhooks removed
K8s->>Webhook: Admission request (CREATE/UPDATE)
alt Validating webhook rules match (backup/physicalbackup)
Webhook->>K8s: Validate (allow/deny)
else No matching validating webhook
Webhook->>K8s: No-op (allow)
end
K8s->>Operator: Resource events (create/update)
Operator->>K8s: Uses RBAC: endpointslices, PVC delete, volumesnapshots, externalmariadbs, physicalbackups
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @IvanHunters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant upgrade of the MariaDB operator to version "25.10.2". The update encompasses bumping version numbers across Helm chart files, modernizing Kubernetes RBAC permissions to leverage "endpointslices" for service discovery, and expanding the operator's capabilities to manage new custom resources like "ExternalMariaDBs" and "PhysicalBackups", alongside "VolumeSnapshots". Additionally, default MariaDB image configurations have been revised, and the webhook setup has been adjusted to remove a mutating webhook for MariaDBs and introduce a validating webhook for physical backups. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request bumps the MariaDB operator version from 0.38.1 to 25.10.2. This major version change introduces several new features and improvements, such as support for physicalbackups, externalmariadbs, and volumesnapshots. The RBAC rules have been updated accordingly to support these new features. Notably, the operator now migrates from Endpoints to EndpointSlices, which is a good modernization. My review focuses on the RBAC permission changes, specifically the new delete permission for PersistentVolumeClaims.
| - persistentvolumeclaims | ||
| verbs: | ||
| - create | ||
| - delete |
There was a problem hiding this comment.
The addition of the delete verb for persistentvolumeclaims grants the operator highly destructive permissions. While this might be necessary for certain lifecycle operations, it increases the risk of accidental data loss. Please ensure this permission is strictly necessary and that the operator's logic handles PVC deletion with extreme care, for example, by making it opt-in or dependent on the PVC's reclaim policy.
| - persistentvolumeclaims | ||
| verbs: | ||
| - create | ||
| - delete |
There was a problem hiding this comment.
The addition of the delete verb for persistentvolumeclaims grants the operator highly destructive permissions. While this might be necessary for certain lifecycle operations, it increases the risk of accidental data loss. Please ensure this permission is strictly necessary and that the operator's logic handles PVC deletion with extreme care, for example, by making it opt-in or dependent on the PVC's reclaim policy.
Signed-off-by: IvanHunters <xorokhotnikov@gmail.com>
Update MariaDB operator to a new version.
What this PR does
Release note
Summary by CodeRabbit
New Features
Updates
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.