-
Notifications
You must be signed in to change notification settings - Fork 136
Update Kube-OVN v1.14.11 #1514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Kube-OVN v1.14.11 #1514
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughUpdates kube-ovn to v1.14.11 across chart, values, and Dockerfile. Tightens CRD OpenAPI schemas with explicit integer min/max bounds. Adds OVN_IPSEC_KEY_DIR configuration and remaps the IPsec keys hostPath in the DaemonSet when IPsec is enabled. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Helm as Helm Chart
participant K8s as Kubernetes API Server
participant DS as ovncni DaemonSet
participant Node as Node Filesystem
Helm->>K8s: install/upgrade kube-ovn (Chart.yaml, values.yaml)
Note over K8s: Apply CRDs with tightened numeric min/max validation
K8s-->>Helm: CRDs accepted/rejected per schema bounds
Helm->>K8s: apply DaemonSet (ovncni-ds.yaml)
alt ENABLE_OVN_IPSEC = true
K8s->>DS: create/update Pods with IPsec key volume
DS->>Node: mount hostPath from OVN_IPSEC_KEY_DIR
else ENABLE_OVN_IPSEC = false
K8s->>DS: create/update Pods without IPsec key mount
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @kvaps, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the Kube-OVN component to its v1.14.11 release. The update primarily involves synchronizing version numbers across various configuration files and Dockerfile, alongside significant refinements to the Custom Resource Definition (CRD) schemas for improved validation. Additionally, it introduces a new configuration option for specifying the storage path of OVN IPsec keys, providing greater control over the deployment environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates Kube-OVN to version v1.14.11. The changes include updating version numbers in the Helm chart, values file, and Dockerfile. It also incorporates upstream improvements to the Kube-OVN CRDs by adding stricter validation rules, and fixes the host path for OVN IPsec keys. The changes look good overall. I've added a couple of suggestions to improve maintainability and adherence to standards in the packaging files.
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: v1.14.5 | ||
| version: v1.14.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the Semantic Versioning specification (SemVer 2.0.0), which is referenced in the comment on the preceding line, version numbers should be in the format X.Y.Z. The v prefix is not part of the standard. While many tools tolerate it, it's best practice to omit it for strict compliance and better interoperability.
version: 1.14.11| ARG TAG=v1.14.11 | ||
| RUN git clone --branch ${TAG} --depth 1 https://github.com/kubeovn/kube-ovn /source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve maintainability and avoid repeating the version string, you can reuse the VERSION argument defined at the top of the file. This prevents having to update the version in multiple places in the future.
ARG VERSION
RUN git clone --branch ${VERSION} --depth 1 https://github.com/kubeovn/kube-ovn /source
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
packages/system/kubeovn/charts/kube-ovn/Chart.yaml(1 hunks)packages/system/kubeovn/charts/kube-ovn/templates/kube-ovn-crd.yaml(8 hunks)packages/system/kubeovn/charts/kube-ovn/templates/ovncni-ds.yaml(1 hunks)packages/system/kubeovn/charts/kube-ovn/values.yaml(2 hunks)packages/system/kubeovn/images/kubeovn/Dockerfile(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Pull Request
packages/system/kubeovn/charts/kube-ovn/templates/ovncni-ds.yaml
[error] 1-1: Build failed due to Go version mismatch: go.mod requires Go 1.25.2 or higher, but the builder is using Go 1.24.8.
packages/system/kubeovn/images/kubeovn/Dockerfile
[error] 1-1: Build failed due to Go version mismatch: go.mod requires Go 1.25.2 or higher, but the builder is using Go 1.24.8.
packages/system/kubeovn/charts/kube-ovn/values.yaml
[error] 1-1: Build failed due to Go version mismatch: go.mod requires Go 1.25.2 or higher, but the builder is using Go 1.24.8.
packages/system/kubeovn/charts/kube-ovn/Chart.yaml
[error] 1-1: Build failed due to Go version mismatch: go.mod requires Go 1.25.2 or higher, but the builder is using Go 1.24.8.
packages/system/kubeovn/charts/kube-ovn/templates/kube-ovn-crd.yaml
[error] 1-1: Build failed due to Go version mismatch: go.mod requires Go 1.25.2 or higher, but the builder is using Go 1.24.8.
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Signed-off-by: Andrei Kvapil kvapss@gmail.com
What this PR does
Release note
Summary by CodeRabbit
New Features
Chores