Skip to content

Commit 02c0e14

Browse files
committed
fix(AppTitle): Use direct Svg instead of Icon to avoid DOM error
In AppTitle, we used Icon by habit but it is not necessary. On the contrary, TwakeTextIcon is not a square icon so it has some internal behavior we tried to disable by using width="auto". However, this is passed to the underlying <svg> which do not support width="auto". It avoid the following error: `Error: <svg> attribute width: Expected length, "auto".`
1 parent ecc5f79 commit 02c0e14

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

react/AppTitle/index.jsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,10 @@ const AppTitle = ({ appIcon, appTextIcon }) => {
2121
size="32"
2222
className={styles['c-apptitle-app-icon']}
2323
/>
24-
<Icon
25-
icon={TwakeTextIcon}
26-
width="auto"
24+
<TwakeTextIcon
2725
height="22"
2826
className={cx(
2927
'u-mr-half',
30-
'u-w-auto',
3128
isLight ? styles['c-apptitle-light'] : styles['c-apptitle-dark']
3229
)}
3330
/>

0 commit comments

Comments
 (0)