Revert "Merge branch_9x into fs/branch_9x (up to ccf4b198ec328095d45d2746189dc8ca633e8bcf)"#21
Merged
hiteshk25 merged 1 commit intofs/branch_9xfrom Jul 18, 2023
Conversation
|
What do you mean for we merged all commits in that PR? Wouldn't we want to merge our fs/branch_9x to be up to date with the common release ancestor for lucene? Just want to make sure I understand the flow here for PRs. |
Collaborator
Author
We squashed all commits in the last PR, instead of just merging |
justinrsweeney
approved these changes
Jul 18, 2023
justinrsweeney
left a comment
There was a problem hiding this comment.
Ah okay, so will do a new merge to fs/branch_9x instead of a squash. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #20
we merged all commits in that PR