Extend behavior of fail_on_error option to setup failures#46
Merged
afinetooth merged 2 commits intomasterfrom Oct 8, 2024
Merged
Extend behavior of fail_on_error option to setup failures#46afinetooth merged 2 commits intomasterfrom
fail_on_error option to setup failures#46afinetooth merged 2 commits intomasterfrom
Conversation
…r find the downloaded binary, rather than just to failures in teh coveralls commands, coveralls report or coveralls done.
This was referenced Oct 8, 2024
fail_on_error option's behavior to setup failures like downloading, verifying and finding the coveralls binaryfail_on_error option to setup failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
fail_on_error: falseis set #40Description
Make sure the
fail_on_erroroption also applies to setup tasks:Rather than just to failures of the coveralls commands:
coveralls report; orcoveralls doneTo Do
fail_on_erroroption applies to any failures to download or verify the binaryfail_on_erroroption applies to any failures to find the downloaded binary in the environment