chore(quantic): octokit rule for quantic removed from renovate#3853
Merged
chore(quantic): octokit rule for quantic removed from renovate#3853
Conversation
* feat(commerce): get clientId from Relay instead of state * refactor(event-protocol-utils): set getClientId method * refactor(headless-commerce): use getVisitorId
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support |
erocheleau
approved these changes
Apr 25, 2024
Collaborator
erocheleau
left a comment
There was a problem hiding this comment.
So what you're saying is that it was working all along? 😂
Contributor
Author
indeed x) |
olamothe
approved these changes
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SFINT-5436
This rule was previously added because a new major version of
@octokit/graphqlbroke our implantation in Quantic script that uses this dependency.This turned out to be an issue from their side that was fixed shortly after that new major version : octokit/graphql.js#551
Plus this renovate rules were containing a typo in the library name that prevented the rule from doing its job properly.
we had
"matchPackagePatterns": ["^@otokit/graphql$"],instead of"matchPackagePatterns": ["^@octokit/graphql$"],thus this dependency has been already updated by renovate to the latest version as you can see here:
ui-kit/packages/quantic/package.json
Lines 61 to 62 in 1b28010