Skip to content

feat(headless-commerce): set clientId with storage value#3641

Merged
sallainCoveo merged 2 commits intomasterfrom
feat-LENS-1525-get-clientId-from-Relay
Feb 27, 2024
Merged

feat(headless-commerce): set clientId with storage value#3641
sallainCoveo merged 2 commits intomasterfrom
feat-LENS-1525-get-clientId-from-Relay

Conversation

@sallainCoveo
Copy link
Contributor

Reverting the revert to fix the build!

Context: https://coveord.atlassian.net/browse/LENS-1525
Original PR: #3628

@sallainCoveo sallainCoveo requested a review from a team as a code owner February 26, 2024 18:09
@github-actions
Copy link

github-actions bot commented Feb 26, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 222.4 222.4 0
commerce 335 335 0
search 408.2 408.3 0
insight 338.4 338.5 0
product-listing 340.2 340.3 0
product-recommendation 189.2 189.2 0
recommendation 236.9 236.9 0
ssr 377.6 377.7 0

@sallainCoveo sallainCoveo changed the title Feat lens 1525 get client id from relay Feat(headless/commerce): set clientId with storage value Feb 26, 2024
@louis-bompart louis-bompart changed the title Feat(headless/commerce): set clientId with storage value feat(headless/commerce): set clientId with storage value Feb 26, 2024
@louis-bompart louis-bompart changed the title feat(headless/commerce): set clientId with storage value feat(headless-commerce): set clientId with storage value Feb 26, 2024
@sallainCoveo sallainCoveo force-pushed the feat-LENS-1525-get-clientId-from-Relay branch from 9da589d to 4092d27 Compare February 26, 2024 20:07
@louis-bompart louis-bompart added this pull request to the merge queue Feb 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2024
sallainCoveo and others added 2 commits February 27, 2024 07:19
* feat(commerce): get clientId from Relay instead of state

* refactor(event-protocol-utils): set getClientId method

* refactor(headless-commerce): use getVisitorId
@sallainCoveo sallainCoveo force-pushed the feat-LENS-1525-get-clientId-from-Relay branch from 4092d27 to 54c25ed Compare February 27, 2024 12:19
@sallainCoveo sallainCoveo added this pull request to the merge queue Feb 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2024
@sallainCoveo sallainCoveo added this pull request to the merge queue Feb 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2024
@sallainCoveo sallainCoveo added this pull request to the merge queue Feb 27, 2024
Merged via the queue into master with commit 58bd8d0 Feb 27, 2024
@sallainCoveo sallainCoveo deleted the feat-LENS-1525-get-clientId-from-Relay branch February 27, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants