feat(headless-commerce): set clientId with storage value#3641
Merged
sallainCoveo merged 2 commits intomasterfrom Feb 27, 2024
Merged
feat(headless-commerce): set clientId with storage value#3641sallainCoveo merged 2 commits intomasterfrom
sallainCoveo merged 2 commits intomasterfrom
Conversation
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
|
Spuffynism
approved these changes
Feb 26, 2024
louis-bompart
approved these changes
Feb 26, 2024
9da589d to
4092d27
Compare
* feat(commerce): get clientId from Relay instead of state * refactor(event-protocol-utils): set getClientId method * refactor(headless-commerce): use getVisitorId
4092d27 to
54c25ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting the revert to fix the build!
Context: https://coveord.atlassian.net/browse/LENS-1525
Original PR: #3628