Skip to content

PCBC-987: Fix consistency vector encoding for FTS#163

Merged
avsej merged 1 commit intocouchbase:mainfrom
avsej:fix-search-test
Apr 22, 2024
Merged

PCBC-987: Fix consistency vector encoding for FTS#163
avsej merged 1 commit intocouchbase:mainfrom
avsej:fix-search-test

Conversation

@avsej
Copy link
Copy Markdown
Member

@avsej avsej commented Apr 22, 2024

No description provided.

@avsej avsej requested review from Matt-Woz and thejcfactor April 22, 2024 19:55
thejcfactor
thejcfactor previously approved these changes Apr 22, 2024
Copy link
Copy Markdown

@thejcfactor thejcfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick -- LGTM otherwise (not a breaking change b/c the use of consistency w/ FTS is broken as-is).

Copy link
Copy Markdown

@thejcfactor thejcfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@avsej avsej merged commit 486383d into couchbase:main Apr 22, 2024
@avsej avsej deleted the fix-search-test branch April 22, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants