Skip to content

PCBC-859: Update build scripts and instructions for Windows#158

Merged
avsej merged 4 commits intocouchbase:mainfrom
avsej:PCBC-859-windows-support
Apr 8, 2024
Merged

PCBC-859: Update build scripts and instructions for Windows#158
avsej merged 4 commits intocouchbase:mainfrom
avsej:PCBC-859-windows-support

Conversation

@avsej
Copy link
Copy Markdown
Member

@avsej avsej commented Apr 3, 2024

No description provided.

@avsej avsej requested review from Matt-Woz and raycardillo April 3, 2024 05:52
@avsej
Copy link
Copy Markdown
Member Author

avsej commented Apr 3, 2024

It depends on this change in core: couchbase/couchbase-cxx-client#550, and still has some weird link error on the last step. So I will put as a draft, but contribution is welcome.

@avsej avsej marked this pull request as draft April 3, 2024 05:54
@avsej avsej force-pushed the PCBC-859-windows-support branch from 38d9bd2 to d549210 Compare April 4, 2024 19:36
@avsej
Copy link
Copy Markdown
Member Author

avsej commented Apr 5, 2024

@raycardillo with this patch the instructions seem to work, at least I managed to get it in my environment

> php -d extension=couchbase -i | rg couchbase
couchbase
couchbase => enabled
couchbase_extension_version => 4.2.0
couchbase_extension_revision => 5d98471f9651e2157a160443990d303a0eb1cbc3
couchbase_client_revision => 291ed3da17a0a0d68a599dd25306dbb8eb7febac
couchbase.log_level => no value => no value
couchbase.log_path => no value => no value
couchbase.log_php_log_err => 1 => 1
couchbase.log_stderr => 0 => 0
couchbase.max_persistent => -1 => -1
couchbase.persistent_timeout => -1 => -1

@avsej avsej changed the title PCBC-859: Windows support PCBC-859: Update build scripts and instructions for Windows Apr 5, 2024
@avsej avsej marked this pull request as ready for review April 5, 2024 21:45
Matt-Woz
Matt-Woz approved these changes Apr 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Matt-Woz Matt-Woz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avsej avsej merged commit 9917010 into couchbase:main Apr 8, 2024
@avsej avsej deleted the PCBC-859-windows-support branch April 8, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Matt-Woz Matt-Woz Matt-Woz approved these changes

@raycardillo raycardillo Awaiting requested review from raycardillo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@avsej @Matt-Woz