update in test PessimisticLocking#151
Merged
avsej merged 1 commit intocouchbase:mainfrom Mar 16, 2024
CosmicSaaurabh:update-KV-locking-test
Merged
update in test PessimisticLocking#151avsej merged 1 commit intocouchbase:mainfrom CosmicSaaurabh:update-KV-locking-test
avsej merged 1 commit intocouchbase:mainfrom
CosmicSaaurabh:update-KV-locking-test
Conversation
Matt-Woz
reviewed
Mar 15, 2024
Contributor
Matt-Woz
left a comment
There was a problem hiding this comment.
Unfortunately this will now fail on older server versions, maybe we should just remove the assertion? Alternatively we could replace it with $this->assertContains($res->cas(), [$originalCas, $lockedCas]) which should work with both versions. What do you think @avsej ?
Member
|
I think we should not make any assumptions on the CAS at all. After all it is all about behavior. If the key is locked, it won't be possible to read it. Successful read means correct behavior. So I would just remove this check completely. |
Contributor
Author
|
Okay, i will remove this assert then. |
… locked is same as CAS value after the document gets unlocked
avsej
approved these changes
Mar 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update in test PessimisticLocking, check if CAS value before document locked is same as CAS value after the document gets unlocked