CXXCBC-651: Preserve cached node labels after generating report in app telemetry meter#802
Merged
DemetrisChr merged 2 commits intocouchbase:mainfrom Jul 16, 2025
Conversation
avsej
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a report is generated, we replace the existing
app_telemetry_meter_implwith a new instance of adefault_app_telemetry_meter_impl. This means that the existing node labels cache will be empty, until a new config is seen, and any subsequent reports will possibly have emptynodeandalt_nodeattributes.Changes
default_app_telemetry_meter_implinstance, set its node labels cache to the value it had in the oldapp_telemetry_meter_implinstance.impl_pointer, as it can be modified and accessed from different threads at the same time.Results
ApplicationTelemetrySocketTest in FIT now passes, with the exception of some assertions failing due to CXXCBC-650.