Skip to content

CXXCBC-651: Preserve cached node labels after generating report in app telemetry meter#802

Merged
DemetrisChr merged 2 commits intocouchbase:mainfrom
DemetrisChr:CXXCBC-651-app-telemetry-persist-node-labels
Jul 16, 2025
Merged

CXXCBC-651: Preserve cached node labels after generating report in app telemetry meter#802
DemetrisChr merged 2 commits intocouchbase:mainfrom
DemetrisChr:CXXCBC-651-app-telemetry-persist-node-labels

Conversation

@DemetrisChr
Copy link
Copy Markdown
Contributor

@DemetrisChr DemetrisChr commented Jul 15, 2025

Motivation

When a report is generated, we replace the existing app_telemetry_meter_impl with a new instance of a default_app_telemetry_meter_impl. This means that the existing node labels cache will be empty, until a new config is seen, and any subsequent reports will possibly have empty node and alt_node attributes.

Changes

  • When creating the new default_app_telemetry_meter_impl instance, set its node labels cache to the value it had in the old app_telemetry_meter_impl instance.
  • Add a shared lock to protect the impl_ pointer, as it can be modified and accessed from different threads at the same time.

Results

ApplicationTelemetrySocketTest in FIT now passes, with the exception of some assertions failing due to CXXCBC-650.

@DemetrisChr DemetrisChr merged commit 2d5392f into couchbase:main Jul 16, 2025
26 of 31 checks passed
@DemetrisChr DemetrisChr deleted the CXXCBC-651-app-telemetry-persist-node-labels branch July 16, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants