CXXCBC-704: Handle document_unretrievable from get_multi individual fetch#785
Merged
DemetrisChr merged 1 commit intocouchbase:mainfrom Jun 30, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the error classification in get_multi_orchestrator to correctly handle document_unretrievable errors by adding a new catch clause for op_exception.
- Added catch block for op_exception in classify_error.
- Improved error propagation by mapping external exceptions via error_class_from_external_exception.
Comments suppressed due to low confidence (1)
core/transactions/get_multi_orchestrator.cxx:184
- Consider adding a comment explaining why op_exception is handled separately from transaction_operation_failed to aid future maintainability.
} catch (const op_exception& e) {
Matt-Woz
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fetching a replica now raises a document_unretrievable error that is not wrapped in a transaction_operation_failed. The get_multi error handling should be updated to handle that.
Change
In get_multi_orchestrator's classify_error method, add handling for
op_exceptionResults
ExtGetMultiMissingDocsTest which was previously failing now passes