Skip to content

CXXCBC-694: Handle case where requestID is missing from query response payload#768

Merged
avsej merged 1 commit intocouchbase:mainfrom
DemetrisChr:CXXCBC-694-query-request-id
May 30, 2025
Merged

CXXCBC-694: Handle case where requestID is missing from query response payload#768
avsej merged 1 commit intocouchbase:mainfrom
DemetrisChr:CXXCBC-694-query-request-id

Conversation

@DemetrisChr
Copy link
Copy Markdown
Contributor

@DemetrisChr DemetrisChr commented May 30, 2025

Motivation

We noticed in a FIT run on CI that the SDK throws an exception in situations when an error was returned and requestID was missing. We should just leave it unset to prevent an out_of_range exception from being raised.

Change

  • Don't set request_id in query response if it's not present in the response payload.
  • Update test to expect request_id to be non-empty so we catch any situations where an error hasn't occurred but request_id is missing (which would be a server bug)

@avsej avsej merged commit 87e75cd into couchbase:main May 30, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants