Skip to content

CXXCBC-688: Don't convert Public API TOF from lambda to Core API's TOF, rely on internal state#765

Merged
DemetrisChr merged 1 commit intocouchbase:mainfrom
DemetrisChr:CXXCBC-688-tof-bug
May 23, 2025
Merged

CXXCBC-688: Don't convert Public API TOF from lambda to Core API's TOF, rely on internal state#765
DemetrisChr merged 1 commit intocouchbase:mainfrom
DemetrisChr:CXXCBC-688-tof-bug

Conversation

@DemetrisChr
Copy link
Copy Markdown
Contributor

As part of the GetMulti changes, logic was added that converts the Public API TOF error, to a core exception and throws it. As we lose some of the context in the Public API, this was being done with the FAIL_OTHER error class. This caused many FIT failures, as for some error classes we expect different behaviour, like retries.

It’s not necessary to raise the TOF exceptions if returned from the lambda, as the core must always cache TOF errors internally with the full context around the error and the correct error class.

@DemetrisChr DemetrisChr force-pushed the CXXCBC-688-tof-bug branch from 349aa0c to c92c0f3 Compare May 22, 2025 15:44
@DemetrisChr DemetrisChr force-pushed the CXXCBC-688-tof-bug branch from c92c0f3 to 79298ac Compare May 22, 2025 15:46
@DemetrisChr DemetrisChr merged commit cab40e6 into couchbase:main May 23, 2025
23 of 27 checks passed
@DemetrisChr DemetrisChr deleted the CXXCBC-688-tof-bug branch May 23, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants