CXXCBC-672: Add add_named_parameter and add_positional_parameter to query/analytics options#762
Merged
DemetrisChr merged 2 commits intocouchbase:mainfrom May 9, 2025
Conversation
…uery/analytics options
8d7ca6e to
b44f652
Compare
avsej
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Our existing high-level
positional_parametersandnamed_parameterssetters require the number of parameters to be known at compile time. Whileencoded_positional_parametersandencoded_named_parameterscan be used if the number of parameters is not known at compile time, that's a low-level uncommitted API, so we should provide a high-level alternative.Changes
Add new methods to
analytics_options&query_options–add_named_parameter,add_positional_parameter,clear_positional_parameters, andclear_named_parameters.These allow any number of parameters to be set even when that's not known at compile time, without the user having to serialize them.