Skip to content

CXXCBC-611 & CXXCBC-612: Follow RFC naming for metric operation names#695

Merged
avsej merged 4 commits intocouchbase:mainfrom
DemetrisChr:metric-names
Nov 14, 2024
Merged

CXXCBC-611 & CXXCBC-612: Follow RFC naming for metric operation names#695
avsej merged 4 commits intocouchbase:mainfrom
DemetrisChr:metric-names

Conversation

@DemetrisChr
Copy link
Copy Markdown
Contributor

Motivation

Currently we were recording operation name & code, or path for KV and HTTP operations respectively. According to the Extended Observability RFC, the db.operation metric field should have the same value as outer span names:

“db.operation”: Same as the “outer span names” - for example “get”, “get_and_lock” etc.

Changes

  • Add an observaility_identifier static field to all requests, with the operation name specified in the RFC's outer span name table.
  • Use that field to populate db.operation in metrics. (That field should also be used for the outer spans, will be done under a separate ticket)
  • Fix bug where all HTTP operations were recorded with db.couchbase.service = "kv"
  • Add tests for HTTP operation metrics

@avsej avsej merged commit a797847 into couchbase:main Nov 14, 2024
@DemetrisChr DemetrisChr deleted the metric-names branch November 15, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants