CXXCBC-611 & CXXCBC-612: Follow RFC naming for metric operation names#695
Merged
avsej merged 4 commits intocouchbase:mainfrom Nov 14, 2024
Merged
CXXCBC-611 & CXXCBC-612: Follow RFC naming for metric operation names#695avsej merged 4 commits intocouchbase:mainfrom
avsej merged 4 commits intocouchbase:mainfrom
Conversation
avsej
approved these changes
Nov 13, 2024
avsej
approved these changes
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we were recording operation name & code, or path for KV and HTTP operations respectively. According to the Extended Observability RFC, the
db.operationmetric field should have the same value as outer span names:Changes
observaility_identifierstatic field to all requests, with the operation name specified in the RFC's outer span name table.db.operationin metrics. (That field should also be used for the outer spans, will be done under a separate ticket)db.couchbase.service="kv"