CXXCBC-624: Fix user agent ID generation#692
Merged
avsej merged 1 commit intocouchbase:mainfrom Nov 7, 2024
Merged
Conversation
7beed27 to
bf5254c
Compare
SDK-RFC couchbase#47 expects space after version and all extra information must be surrounded with parentheses. Additionally this patch allows wrappers to override the ID during compile time, so that C++SDK version will be moved to the extras section of the identifier. * standalone C++SDK build ("cbc" is runtime extra part) "cxx/1.0.3+5.1.074ce40c (Darwin/arm64;ssl/0x30400000;cbc)" * cmake -DCOUCHBASE_CXX_CLIENT_WRAPPER_UNIFIED_ID=ruby/4.5.3 "ruby/4.5.3 (cxx/1.0.3+5.1.074ce40c;Darwin/arm64;ssl/0x30400000;cbc)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK-RFC-47 expects space after version and all extra information must be surrounded with parentheses.
Additionally this patch allows wrappers to override the ID during compile time, so that C++SDK version will be moved to the extras section of the identifier.
standalone C++SDK build ("cbc" is runtime extra part)
cmake -DCOUCHBASE_CXX_CLIENT_WRAPPER_UNIFIED_ID=ruby/4.5.3