CXXCBC-615: Expose insert_raw & replace_raw in core txns attempt ctx#686
Merged
avsej merged 1 commit intocouchbase:mainfrom Oct 25, 2024
Merged
Conversation
ffc751b to
d3460a6
Compare
thejcfactor
approved these changes
Oct 25, 2024
Contributor
thejcfactor
left a comment
There was a problem hiding this comment.
LGTM 👍
Also tested w/ the PYCBC-1595 changes. Thanks for making the updates!
avsej
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
insert_rawandreplace_rawin the core txns attempt context APIs, which have now been renamed toinsertandreplace.insertandreplacethat use transcoders from the core API, as well as the overloads ofcore::transactions::transaction_get_result::content()that use transcoders