CXXCBC-582: Add cluster labels & system tag in spans#682
Merged
DemetrisChr merged 1 commit intocouchbase:mainfrom Oct 17, 2024
Merged
CXXCBC-582: Add cluster labels & system tag in spans#682DemetrisChr merged 1 commit intocouchbase:mainfrom
DemetrisChr merged 1 commit intocouchbase:mainfrom
Conversation
avsej
approved these changes
Oct 16, 2024
3ed4d5c to
b89bcff
Compare
b89bcff to
6db4880
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Extended Observability RFC revision 25 requires us to record
db.couchbase.cluster_nameanddb.couchbase.cluster_uuidin all spans created by the SDK.Changes
core::tracing::tracer_wrapperclass that watches for config updates and keeps track of cluster labels. We can expand is in the future to DRY creation of certain types of spans that we need to add (request_encoding,dispatch_to_server).db.systemtag and the cluster labels if those are exposed by the cluster. All spans should have these 3 tags.db.systemand cluster labelsResults
Tests pass