CXXCBC-582: Add cluster labels, keyspace & outcome in metrics#677
Merged
avsej merged 1 commit intocouchbase:mainfrom Oct 15, 2024
Merged
Conversation
avsej
reviewed
Oct 15, 2024
175813d to
c55f061
Compare
c55f061 to
6a22460
Compare
avsej
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Extended Observability RFC revisions 24 & 25 require us to record additional metrics tags: bucket, scope, collection, outcome, and cluster labels (name & UUID)
Changes
clusterName&clusterUUIDcore::metrics::meter_wrapperclass that watches for config updates and keeps track of cluster labelsResults
Tests pass
Known issues
Non-KV operation metrics don't currently report collection, bucket and scope names.