Skip to content

CXXCBC-582: Add cluster labels, keyspace & outcome in metrics#677

Merged
avsej merged 1 commit intocouchbase:mainfrom
DemetrisChr:CXXCBC-582-contextual-metrics
Oct 15, 2024
Merged

CXXCBC-582: Add cluster labels, keyspace & outcome in metrics#677
avsej merged 1 commit intocouchbase:mainfrom
DemetrisChr:CXXCBC-582-contextual-metrics

Conversation

@DemetrisChr
Copy link
Copy Markdown
Contributor

Motivation

The Extended Observability RFC revisions 24 & 25 require us to record additional metrics tags: bucket, scope, collection, outcome, and cluster labels (name & UUID)

Changes

  • Update config parsing to include clusterName & clusterUUID
  • Create a new core::metrics::meter_wrapper class that watches for config updates and keeps track of cluster labels
  • Replace all meter references in the core with the meter wrapper
  • The meter wrapper is responsible for encoding the metric attributes & inserts tags for the cluster labels, if those are supported by the cluster
  • Add some tests for KV

Results

Tests pass

Known issues

Non-KV operation metrics don't currently report collection, bucket and scope names.

@DemetrisChr DemetrisChr force-pushed the CXXCBC-582-contextual-metrics branch 3 times, most recently from 175813d to c55f061 Compare October 15, 2024 15:49
@DemetrisChr DemetrisChr force-pushed the CXXCBC-582-contextual-metrics branch from c55f061 to 6a22460 Compare October 15, 2024 15:59
@avsej avsej merged commit fac2264 into couchbase:main Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants