CXXCBC-606: Fix detection of disfunctional node#673
Merged
avsej merged 1 commit intocouchbase:mainfrom Oct 11, 2024
Merged
Conversation
f794095 to
a5cae8c
Compare
* remove "reopen()" API of the stream, the close is asynchronous anyway, so it is not correct to assume that the socket will be ready immediately. * remove open_ flag for stream, and instead proxy it directly to the socket to avoid "operation is already in progress" type of errors when trying to open the same socket twice. * re-arm connection_deadline_ when the socket is ready for data, use KV timeout for whole handshake with the single node. Re-initiate bootstrap using next bootstrap address in case of single node timeout. * reset reading_ flag in case of error. Ensure that the flag is reset if the session is not reading. * handle socket_closed_while_in_flight error, and if it happens during bootstrap, try next node in the list, otherwise preserve old behavior (close the connection, and let bucket to reopen it).
a5cae8c to
9cac3be
Compare
thejcfactor
approved these changes
Oct 11, 2024
Contributor
thejcfactor
left a comment
There was a problem hiding this comment.
LGTM 👍
Tested changes in Node.js client as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reopen()API of the stream, the close is asynchronous anyway, so it is not correct to assume that the socket will be ready immediately.open_flag for stream, and instead proxy it directly to the socket to avoid "operation is already in progress" type of errors when trying to open the same socket twice.connection_deadline_when the socket is ready for data, use KV timeout for whole handshake with the single node. Re-initiate bootstrap using next bootstrap address in case of single node timeout.reading_flag in case of error. Ensure that the flag is reset if the session is not reading.socket_closed_while_in_flighterror, and if it happens during bootstrap, try next node in the list, otherwise preserve old behavior (close the connection, and let bucket to reopen it).