CXXCBC-531: Transfer ownership of range_scan_orchestrator_impl to scan_result#645
Merged
DemetrisChr merged 1 commit intocouchbase:mainfrom Aug 22, 2024
Merged
Conversation
avsej
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
range_scan_orchestrator.scan()method returns, ownership ofrange_scan_orchestrator_implis transferred from therange_scan_orchestratorto thescan_result. This avoids the need to keep a reference to therange_scan_orchestratorwhile fetching items from thescan_result.Each
range_scan_orchestratorinstance is only for a single scan, so no subsequentscan()calls will need to be made.