Skip to content

feat: Change the v0.20.x line to use cosmos DB#768

Closed
ValarDragon wants to merge 5 commits intorelease/v0.20.xfrom
dev/switch_v0.20_line
Closed

feat: Change the v0.20.x line to use cosmos DB#768
ValarDragon wants to merge 5 commits intorelease/v0.20.xfrom
dev/switch_v0.20_line

Conversation

@ValarDragon
Copy link
Contributor

This is done so we can merge #765

@ValarDragon ValarDragon requested a review from a team May 11, 2023 15:19
@ValarDragon ValarDragon changed the title Change the v0.20.x line to use cosmos DB feat: Change the v0.20.x line to use cosmos DB May 11, 2023
@ValarDragon
Copy link
Contributor Author

This CI lint seems wrong? I tried changing both of the nolint's in the codebase, but they do warn for a gocritic problem. (Also these are unchanged by this PR)

@ValarDragon
Copy link
Contributor Author

cc @tac0turtle or anyone who worked on the initial cosmos DB move, any idea why benchmarks is getting build errors for rocksDB and how to fix it?

(Also is this something thats acceptable to merge into v0.20.x line?)

@tac0turtle
Copy link
Contributor

I can look into this. We have different versions for things due to the comet migration so it's confusing.

@julienrbrt
Copy link
Contributor

I can look into this. We have different versions for things due to the comet migration so it's confusing.

I was looking as well lol -> #769
I think we cannot because this will break v0.47.x users.

@ValarDragon
Copy link
Contributor Author

ValarDragon commented May 13, 2023

oh yikes thats super confusing. OK :/

Makes sense with the incompatibalities due to tendermint vs comet vs cosmos. Guess I have to revive the IAVL fork until Osmosis updates its SDK.

Or maybe I make a more questionable version of this batch size tracking for this release line.

@tac0turtle
Copy link
Contributor

tac0turtle commented May 19, 2023

@ValarDragon which version of the sdk do you need this for? we can make it work for your version and use a wrapper if neede

@ValarDragon
Copy link
Contributor Author

Its for SDK v0.45! But I think it shouldn't be a big deal to make a more complicated IAVL change here to track the batch size in IAVL instead of the DB layer for this release line.

@tac0turtle
Copy link
Contributor

lets backport to 0.21 and the app can have a wrapper around the db for use with 0.45

@tac0turtle tac0turtle closed this May 30, 2023
@julienrbrt julienrbrt deleted the dev/switch_v0.20_line branch February 3, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants