fix: validate branch node must have both children#656
fix: validate branch node must have both children#656yihuang wants to merge 2 commits intocosmos:masterfrom
Conversation
|
yeah, I also thought this is weird, but this will be updated in adr-001 imp. It allows having one child nodekey, even zero nodekey. |
"It allows having one child nodekey", can you elaborate on that? do you mean one child branch node? |
|
no, what I mean is it is possible to have one or zero node-key, since we are using the I know this is a bit far from this topic, but it will be updated in new imp, so I'd like to keep it at this time. tbh I am facing conflicts in my open PRs so frequently. |
BTW, we have some new ideas regarding iavl storage recently. |
|
we can close this one, @yihuang @tac0turtle ? |
This is what confused me when reading the code, to my understanding branch node always have two children, but the code seems to allow single child branch nodes?
marked as draft to wait for feedbacks first.