Skip to content

feat: add nodeKey integer field#593

Merged
cool-develope merged 2 commits into592/nonce-keyfrom
592/subtask-1
Oct 19, 2022
Merged

feat: add nodeKey integer field#593
cool-develope merged 2 commits into592/nonce-keyfrom
592/subtask-1

Conversation

@cool-develope
Copy link
Contributor

@cool-develope cool-develope commented Oct 18, 2022

ref: #592
ref: #137

@cool-develope cool-develope requested a review from a team October 18, 2022 12:10
@cool-develope cool-develope marked this pull request as draft October 18, 2022 12:12
@cool-develope cool-develope marked this pull request as ready for review October 18, 2022 13:33
Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cool-develope
Copy link
Contributor Author

utACK

I think the tests are already covered by the original tests because we are triggering errors when decode and encode the node.

@tac0turtle
Copy link
Contributor

sorry, meant I didnt pull and test it.

@cool-develope cool-develope merged commit 7204160 into 592/nonce-key Oct 19, 2022
@cool-develope cool-develope deleted the 592/subtask-1 branch October 19, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants