fix(nodedb): fix race between updating fast node cache and db commit (backport #1142)#1147
Merged
Merged
Conversation
Contributor
Author
|
Cherry-pick of 146f723 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
mattac21
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a race condition where concurrent
GetFastNodecalls (from RPC queries) can repopulate the fast node cache with stale data that is about to be overridden from the tree duringSaveVersion. AfterCommitwithinSaveVersionthe cache is not repopulated with the correct data from the tree, causing the cache to serve that stale data to future readers. At the application level, this leads to an app hash mismatches.To fix this, we introduce a
pendingFastNodeAdditionsandpendingFastNodeRemovalsthat store changes to the fast node cache when adding nodes viasaveFastNodeUnlockedorDeleteFastNode. We then defer the addition or removal of nodes from the fast node cache until after the tree changes commit, meaning there is no period of time where we could have removed a node from the cache, then brought back up an incorrect value from the tree.This also fixes a separate race between
SaveVersionand accessinggetLatestVersionthat was exercised by the regression tests.This is an automatic backport of pull request #1142 done by Mergify.