Skip to content

fix: get latest version in store after legacy pruning fails (backport #1067)#1068

Merged
aljo242 merged 2 commits into
release/v1.2.xfrom
mergify/bp/release/v1.2.x/pr-1067
Mar 27, 2025
Merged

fix: get latest version in store after legacy pruning fails (backport #1067)#1068
aljo242 merged 2 commits into
release/v1.2.xfrom
mergify/bp/release/v1.2.x/pr-1067

Conversation

@mergify

@mergify mergify Bot commented Mar 27, 2025

Copy link
Copy Markdown
Contributor

Description

Currently if legacy pruning fails it sets the firstVersion to latestLegacyVersion + 1

That works under the assumption that if legacy pruning fails that the non-legacy node is the first version is available in the store, this is not the case, and the code will then linearly iterate until it finds the next version, which could be a long wait.

Context

please read #1063 for context on this issue

What this function does

  • A binary search to find the latest non-legacy version in the store
  • This is a monkey patch and should only run only once when a node start pruning then never again, then the cached first version should be kept per node pruning session

What should actually happen

  • Pruning should succeed for legacy node
  • We should still search for the latest none-legacy node

Summary by CodeRabbit

  • New Features

    • Enhanced the process for cleaning up outdated versions, ensuring the system retains only valid data for improved reliability.

  • Tests

    • Added comprehensive tests that validate the improved version cleanup under various scenarios.
This is an automatic backport of pull request #1067 done by [Mergify](https://mergify.com).

@mergify mergify Bot requested a review from a team March 27, 2025 14:58
@mergify mergify Bot mentioned this pull request Mar 27, 2025
Merged
@coderabbitai

coderabbitai Bot commented Mar 27, 2025

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aljo242 aljo242 merged commit 0eea863 into release/v1.2.x Mar 27, 2025
@aljo242 aljo242 deleted the mergify/bp/release/v1.2.x/pr-1067 branch March 27, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aljo242 aljo242 aljo242 approved these changes

+1 more reviewer

@PaddyMc PaddyMc PaddyMc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PaddyMc @aljo242