Skip to content

feat: allow saving version 0 (backport #1002)#1003

Merged
tac0turtle merged 1 commit intorelease/v1.3.xfrom
mergify/bp/release/v1.3.x/pr-1002
Nov 4, 2024
Merged

feat: allow saving version 0 (backport #1002)#1003
tac0turtle merged 1 commit intorelease/v1.3.xfrom
mergify/bp/release/v1.3.x/pr-1002

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 4, 2024

This patch makes SetInitialVersion(0) calls valid, which previously would error during SaveVersion. This is particularly useful from server/v2 which processes and saves a Genesis block at version initialHeight - 1, which is 0 in the default case.

Unrelated to above is some clean up; legacydump is a compiled binary file and shouldn't be committed. An amd64 binary is presently in master, which doesn't run on e.g. arm64. Instead of this, removed the binary and updated the Makefile and Github action to build where required (by tests).

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Enhanced version management capabilities in the MutableTree structure.
    • Improved error handling and validation in the nodeDB structure.
    • Added tracking for initial version status in the Options configuration.
    • New test cases added for comprehensive coverage of MutableTree functionality.
    • Introduced a build step for the legacydump binary in the CI process.

  • Bug Fixes

    • Adjusted return value in version retrieval to better indicate absence of versions.

  • Documentation

    • Updated method signatures to reflect changes in version handling and error management.
    • Revised documentation to clarify updates in the DeleteVersionsFrom method.
    • Added entries to .gitignore to exclude unnecessary files and directories.
This is an automatic backport of pull request #1002 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team November 4, 2024 13:46
@mergify mergify bot mentioned this pull request Nov 4, 2024
Merged
@coderabbitai
Copy link

coderabbitai bot commented Nov 4, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tac0turtle tac0turtle merged commit 7043d8f into release/v1.3.x Nov 4, 2024
@tac0turtle tac0turtle deleted the mergify/bp/release/v1.3.x/pr-1002 branch November 4, 2024 19:12
@kocubinski kocubinski mentioned this pull request Nov 5, 2024
Merged
12 tasks
@mergify mergify bot mentioned this pull request Nov 6, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kocubinski kocubinski kocubinski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kocubinski @tac0turtle