Skip to content

rules/sdk: allow hash.Hash.Write et al to ignore errors since contract permits#66

Merged
odeke-em merged 1 commit intomasterfrom
G703-allowlist-for-errors-that-can-be-ignored
Oct 23, 2022
Merged

rules/sdk: allow hash.Hash.Write et al to ignore errors since contract permits#66
odeke-em merged 1 commit intomasterfrom
G703-allowlist-for-errors-that-can-be-ignored

Conversation

@odeke-em
Copy link
Contributor

Adds an allowList so that types and methods that don't need an error check. That reduces false positives.

Fixes #63

…t permits

Adds an allowList so that types and methods that don't need
an error check. That reduces false positives.

Fixes #63
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.85%. Comparing base (05a47ad) to head (b14268e).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   71.85%   71.85%           
=======================================
  Files           9        9           
  Lines         636      636           
=======================================
  Hits          457      457           
  Misses        150      150           
  Partials       29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odeke-em odeke-em merged commit b887802 into master Oct 23, 2022
@odeke-em odeke-em deleted the G703-allowlist-for-errors-that-can-be-ignored branch October 23, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rules/sdk: G702: Blocklisted import crypto/rand should not flag for crypto related code

2 participants