Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

merge pr #821#866

Merged
freddyli7 merged 1 commit intofreddy/stargate-integration-fixfrom
freddy/stargate-821
Apr 19, 2021
Merged

merge pr #821#866
freddyli7 merged 1 commit intofreddy/stargate-integration-fixfrom
freddy/stargate-821

Conversation

@freddyli7
Copy link
Contributor

Closes: #821

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@freddyli7 freddyli7 merged commit 3946de3 into freddy/stargate-integration-fix Apr 19, 2021
@freddyli7 freddyli7 deleted the freddy/stargate-821 branch April 19, 2021 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant