Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

fix chainid error#758

Closed
araskachoi wants to merge 1 commit intostargatefrom
araska/stargate-fixchainid
Closed

fix chainid error#758
araskachoi wants to merge 1 commit intostargatefrom
araska/stargate-fixchainid

Conversation

@araskachoi
Copy link
Copy Markdown
Contributor

@araskachoi araskachoi commented Jan 29, 2021

Closes: #XXX

Description

There was an issue where the ethermintd start cmd requires a chainID within its context. However, there was none passed. This PR will allow for the clientCtx.ChainID to be passed as a flag (ethermintd start --chain-id $CHAINID) or the chainID will be read from a valid geneisfile from serverCtx.Config.GenesisFile().

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@araskachoi
Copy link
Copy Markdown
Contributor Author

araskachoi commented Jan 29, 2021

This resolves the invalid Chain ID error that was throwing from ethermintd start.

However, there is another issue that is not resolved here. The error log is as below:

E[2021-01-29|01:39:24.555] failed to get keybase info                   module=json-rpc namespace=eth error="unknown keyring backend "
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x110 pc=0x1989510]

goroutine 184 [running]:
github.com/cosmos/ethermint/rpc/namespaces/eth/filters.(*EventSystem).subscribe(0xc000c14580, 0xc0001dc000, 0xc000081560, 0x471e65, 0xc000529800, 0x200000003)
        /ethermint/rpc/namespaces/eth/filters/filter_system.go:114 +0x410
github.com/cosmos/ethermint/rpc/namespaces/eth/filters.EventSystem.SubscribePendingTxs(0x2298c40, 0xc000042080, 0x0, 0x0, 0x0, 0xc00056c420, 0x0, 0x0, 0x0, 0x0, ...)
        /ethermint/rpc/namespaces/eth/filters/filter_system.go:249 +0x22f
github.com/cosmos/ethermint/rpc/namespaces/eth/filters.(*EventSystem).eventLoop(0xc000d00680)
        /ethermint/rpc/namespaces/eth/filters/filter_system.go:295 +0x98
created by github.com/cosmos/ethermint/rpc/namespaces/eth/filters.NewEventSystem
        /ethermint/rpc/namespaces/eth/filters/filter_system.go:88 +0x24d

[WIP] - Will continue to investigate and resolve.

@freddyli7 freddyli7 mentioned this pull request Feb 8, 2021
Merged
@fedekunze
Copy link
Copy Markdown
Contributor

fedekunze commented Feb 28, 2021

this is now fixed on development

@fedekunze fedekunze closed this Feb 28, 2021
@fedekunze fedekunze deleted the araska/stargate-fixchainid branch February 28, 2021 13:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fedekunze fedekunze Awaiting requested review from fedekunze

@noot noot Awaiting requested review from noot

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@araskachoi @fedekunze