Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

fix the anteHandler print error#756

Merged
fedekunze merged 2 commits intocosmos:developmentfrom
AaronZgl:fix-ante-print-err
Jan 29, 2021
Merged

fix the anteHandler print error#756
fedekunze merged 2 commits intocosmos:developmentfrom
AaronZgl:fix-ante-print-err

Conversation

@AaronZgl
Copy link

@AaronZgl AaronZgl commented Jan 28, 2021

Closes #757

Description

When the gas fee is insufficient, the user should be told how much the minimum fees is needed, rather than how much the minimum gas price is needed.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze merged commit e1349e4 into cosmos:development Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong comparison between fees and gas price

2 participants