Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Fix mis-calculate block hash in evm related method#755

Merged
fedekunze merged 4 commits intocosmos:developmentfrom
louisliu2048:xiong/fix-cal-blockhash-misused
Feb 1, 2021
Merged

Fix mis-calculate block hash in evm related method#755
fedekunze merged 4 commits intocosmos:developmentfrom
louisliu2048:xiong/fix-cal-blockhash-misused

Conversation

@louisliu2048
Copy link

@louisliu2048 louisliu2048 commented Jan 28, 2021 •
edited by fedekunze
Loading

Closes #721 and closes #751

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@louisliu2048
Copy link
Author

louisliu2048 commented Jan 28, 2021

According to my observation, as long as you update the CHANGELOG.md file, the following step will always fail:
image
Maybe this check method should be update and remove something related to CHANGELOG.md git diff.

fedekunze
fedekunze approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze fedekunze merged commit 6d11e23 into cosmos:development Feb 1, 2021
This was referenced Feb 1, 2021
Closed
Closed
@KamiD KamiD mentioned this pull request Feb 1, 2021
Merged
11 tasks
This was referenced Feb 16, 2021
Closed
Closed
@freddyli7 freddyli7 mentioned this pull request Apr 20, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@noot noot Awaiting requested review from noot

1 more reviewer

@fedekunze fedekunze fedekunze approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect calculate blockchain hash in evm rpc module Mismatch Block Hash in RPC Response

2 participants

@louisliu2048 @fedekunze