Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Fix panic in AnteHandler when gas price larger than 100000#750

Merged
fedekunze merged 6 commits intocosmos:developmentfrom
KamiD:fix-precision-error
Jan 27, 2021
Merged

Fix panic in AnteHandler when gas price larger than 100000#750
fedekunze merged 6 commits intocosmos:developmentfrom
KamiD:fix-precision-error

Conversation

@KamiD
Copy link

@KamiD KamiD commented Jan 27, 2021

Closes: #749

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@KamiD KamiD requested review from fedekunze and noot as code owners January 27, 2021 06:23
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@fedekunze fedekunze merged commit 16f1dab into cosmos:development Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

function AnteHandler of the objectEthMempoolFeeDecorator will be panic when setting gas price lager than 100000

2 participants