This repository was archived by the owner on Nov 30, 2021. It is now read-only.
Merged
Conversation
Contributor
|
how does cosmjs work? it seems like it uses a pre-funded account? we should probably discuss this on standup since we'll need to update the existing faucet |
Contributor
|
i dont think we ever used the faucet module - i believe we are setting up some "pseudo-faucet" account that just does a value transfer to anyone who requests. I think we have tried to use cosmjs faucet before but was not working for us. There was an issue with the bech32 prefixing and a few other prefixing errs but will try to see if it behaves now (with all the changes we've made) |
araskachoi
approved these changes
Jan 7, 2021
Contributor
araskachoi
left a comment
There was a problem hiding this comment.
looks fine! might want to remove references of faucet in the init file and anywhere else (init.sh, init-test-node.sh, etc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove faucet module in favor of
@cosmjs/faucet