Roll back CommitStateDB after failing to execute handler in evm module#677
Roll back CommitStateDB after failing to execute handler in evm module#677fedekunze merged 8 commits intocosmos:developmentfrom
Conversation
|
It's ok for me to use this as a short term approach. I think we might want to set everything to store instead of keeping "dirty" arrays/maps. This would be a large refactor of the evm module but it also will increase the performance as we won't need to iterate over the dirty entries during |
fedekunze
left a comment
There was a problem hiding this comment.
Thanks @summerpro! Could you add a test case to ensure this is not broken in the future?
Yes, I agree with you, the refactored solution should be able to solve #667 #668 #669 |
You're welcome. Ok i will add it tomorrow |
d7143b5 to
4989c3e
Compare
|
@fedekunze Can this pr be merged? |
Closes: #668 #669
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)