Skip to content

docs: add newline to versions file#7938

Merged
mergify[bot] merged 3 commits intomasterfrom
docs-versions-fix
Nov 17, 2020
Merged

docs: add newline to versions file#7938
mergify[bot] merged 3 commits intomasterfrom
docs-versions-fix

Conversation

@fadeev
Copy link
Contributor

@fadeev fadeev commented Nov 14, 2020 •
edited
Loading

There is a missing newline at the end of versions file that prevents make build-docs script from reading both lines (versions) of the file.

I believe there is still a bug related to code blocks:

Vue warn]: Error in render: "TypeError: Cannot read property 'replace' of undefined"

found in

---> <CodeBlock>
       <VA3a56bca>
         <Content>
           <LayoutDefault>
             <Anonymous>
               <Root>
[Vue warn]: Error in render: "TypeError: Cannot read property 'replace' of undefined"

found in

---> <CodeBlock>
       <V2c1bdf31>
         <Content>
           <LayoutDefault>
             <Anonymous>
               <Root>
error Error rendering /basics/app-anatomy.html: false
undefined
error Error rendering /building-modules/module-interfaces.html: false
undefined
TypeError: Cannot read property 'replace' of undefined
    at VueComponent.highlighted (node_modules/@cosmos-ui/vue/src/CodeBlock/CodeBlock.vue:501:13)
    at Proxy.CodeBlockvue_type_template_id_b6cbde80_scoped_true_render (node_modules/@cosmos-ui/vue/src/CodeBlock/CodeBlock.vue?910b:4:2516)
    at VueComponent.Vue._render (/Users/fadeev/github.com/cosmos/cosmos-sdk/docs/node_modules/vue/dist/vue.runtime.common.dev.js:3538:22)
    at resolve (/Users/fadeev/github.com/cosmos/cosmos-sdk/docs/node_modules/vue-server-renderer/build.dev.js:8415:27)
    at waitForServerPrefetch (/Users/fadeev/github.com/cosmos/cosmos-sdk/docs/node_modules/vue-server-renderer/build.dev.js:8287:3)
    at renderComponentInner (/Users/fadeev/github.com/cosmos/cosmos-sdk/docs/node_modules/vue-server-renderer/build.dev.js:8426:3)
    at renderComponent (/Users/fadeev/github.com/cosmos/cosmos-sdk/docs/node_modules/vue-server-renderer/build.dev.js:8383:5)
    at RenderContext.renderNode (/Users/fadeev/github.com/cosmos/cosmos-sdk/docs/node_modules/vue-server-renderer/build.dev.js:8294:5)
    at RenderContext.next (/Users/fadeev/github.com/cosmos/cosmos-sdk/docs/node_modules/vue-server-renderer/build.dev.js:2598:23)
    at RenderContext.cachedWrite [as write] (/Users/fadeev/github.com/cosmos/cosmos-sdk/docs/node_modules/vue-server-renderer/build.dev.js:2451:9)
    at RenderContext.renderNode (/Users/fadeev/github.com/cosmos/cosmos-sdk/docs/node_modules/vue-server-renderer/build.dev.js:8305:13)
    at RenderContext.next (/Users/fadeev/github.com/cosmos/cosmos-sdk/docs/node_modules/vue-server-renderer/build.dev.js:2598:23)
    at RenderContext.cachedWrite [as write] (/Users/fadeev/github.com/cosmos/cosmos-sdk/docs/node_modules/vue-server-renderer/build.dev.js:2451:9)
    at RenderContext.next (/Users/fadeev/github.com/cosmos/cosmos-sdk/docs/node_modules/vue-server-renderer/build.dev.js:2602:25)
    at RenderContext.cachedWrite [as write] (/Users/fadeev/github.com/cosmos/cosmos-sdk/docs/node_modules/vue-server-renderer/build.dev.js:2451:9)
    at RenderContext.next (/Users/fadeev/github.com/cosmos/cosmos-sdk/docs/node_modules/vue-server-renderer/build.dev.js:2602:25)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! docs@1.0.0 build: `trap 'exit 0' SIGINT; vuepress build --no-cache`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the docs@1.0.0 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/fadeev/.npm/_logs/2020-11-14T16_20_19_877Z-debug.log

cc @lovincyrus

@fadeev fadeev closed this Nov 14, 2020
@fadeev fadeev reopened this Nov 14, 2020
@clevinson
Copy link
Contributor

clevinson commented Nov 15, 2020

Is this ready for review? I can't get the docs to build locally, getting the following error when running make build-docs:

Error in processing description: $page.content is undefined
Error in processing frontmatter: $page.content is undefined
Error in processing headings.

@lovincyrus
Copy link
Contributor

lovincyrus commented Nov 16, 2020

I believe there is still a bug related to code blocks:

Similar to cosmos/vuepress-theme-cosmos#140

There should be broken URLs in the specific path, /basics/app-anatomy.html and /building-modules/module-interfaces.html

@lovincyrus
Copy link
Contributor

lovincyrus commented Nov 16, 2020 •
edited
Loading

Regarding:

There should be broken URLs in the specific path, /basics/app-anatomy.html and /building-modules/module-interfaces.html

image

It builds fine locally. 👌

@lovincyrus
Copy link
Contributor

lovincyrus commented Nov 16, 2020

After running make build-docs:

Switched to branch 'master'
Your branch is up to date with 'origin/master'.

Switched to branch 'launchpad/backports'
Your branch is up to date with 'origin/launchpad/backports'.

image

The build errors will be fixed once we merge #7833 @fadeev

@lovincyrus
Copy link
Contributor

lovincyrus commented Nov 16, 2020

Error in processing description: $page.content is undefined
Error in processing frontmatter: $page.content is undefined
Error in processing headings.

These minor warnings/errors are not blocking the docs build as described by @fadeev

Created an issue for this cosmos/vuepress-theme-cosmos#160

@fadeev
Copy link
Contributor Author

fadeev commented Nov 17, 2020

Great, thanks @lovincyrus 🙏

@fadeev fadeev marked this pull request as ready for review November 17, 2020 07:38
@fadeev
Copy link
Contributor Author

fadeev commented Nov 17, 2020

@clevinson this should be ready for review now.

@mergify mergify bot merged commit b90bacb into master Nov 17, 2020
@mergify mergify bot deleted the docs-versions-fix branch November 17, 2020 19:25
@clevinson clevinson mentioned this pull request Dec 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clevinson clevinson Awaiting requested review from clevinson

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

2 more reviewers

@alessio alessio alessio approved these changes

@lovincyrus lovincyrus lovincyrus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fadeev @clevinson @lovincyrus @alessio