WIP: Replace GenesisTx with StdTx by alessio · Pull Request #2422 · cosmos/cosmos-sdk

alessio · 2018-09-29T15:44:51Z

Ref #1890

Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (docs/)
Added entries in PENDING.md with issue #
rereviewed Files changed in the github PR explorer

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

zmanian · 2018-09-29T20:32:41Z

Hey would it be possible think about aligning the requirements here with our needs to Starfish for launch?

Some description of the idea of Starfish.

https://gist.github.com/zmanian/88fdd41421d363d11adbcf98d3367a4c

codecov · 2018-10-01T11:44:55Z

Codecov Report

Merging #2422 into develop will increase coverage by 3.38%.
The diff coverage is 9.52%.

@@             Coverage Diff             @@
##           develop    #2422      +/-   ##
===========================================
+ Coverage    57.87%   61.25%   +3.38%     
===========================================
  Files          140      122      -18     
  Lines         8119     7519     -600     
===========================================
- Hits          4699     4606      -93     
+ Misses        3123     2594     -529     
- Partials       297      319      +22

cwgoes · 2018-10-02T10:44:52Z

@zaki What will be the process for collecting genesis accounts for the Hub? Will the ICF issue a "suggested" allocation list, which node operators can then combine with their list of genesis transactions locally - or will the ICF collate genesis transactions itself and provide a full genesis file?

cwgoes · 2018-10-02T12:10:22Z

Let's include this in 0.25.

zmanian · 2018-10-03T01:30:06Z

It's gonna be more the like here are allocations + genesis txs + tools for reading eth and Bitcoin blockchains.

jackzampolin · 2018-10-04T00:59:04Z

Lets make sure we at least have an eye toward starfish requirements while implementing this. Lets sync on this @alessio

zmanian · 2018-10-06T22:32:58Z

I feel like we can implement Starfish as wrapper around this functionality.

jaekwon · 2018-10-08T00:09:17Z

Reviewing...

Finalize gaiacli tx create-validator --genesis-format

jaekwon · 2018-10-16T07:56:24Z

-				Power:  1,
-				Name:   fmt.Sprintf("validator-%d", i+1),
-			},
+	for i:=0 ; i<nValidators; i++ {


dry w/ above

jaekwon · 2018-10-16T08:01:06Z

 // SignStdTx appends a signature to a StdTx and returns a copy of a it. If appendSig
 // is false, it replaces the signatures already attached with the new signature.
-func SignStdTx(txBldr authtxb.TxBuilder, cliCtx context.CLIContext, name string, stdTx auth.StdTx, appendSig bool) (auth.StdTx, error) {
+func SignStdTx(txBldr authtxb.TxBuilder, cliCtx context.CLIContext, name string, stdTx auth.StdTx, appendSig bool, offline bool) (auth.StdTx, error) {


ideally is maybe SignStdTxOptions struct/ptr? But this is maybe fine for now w/ comment & TODO in comments in code... (for me anyways)

jaekwon · 2018-10-16T08:28:57Z

+	if len(req.Validators) > 0 {
+		if len(req.Validators) != len(validators) {
+			panic(fmt.Errorf("len(RequestInitChain.Validators) != len(validators) (%d != %d) ", len(req.Validators), len(validators)))
+		}


TODO sort and equality check...

jaekwon · 2018-10-16T08:30:25Z

 // State to Unmarshal
 type GenesisState struct {
 	Accounts  []GenesisAccount   `json:"accounts"`
+	Txs       []json.RawMessage  `json:"txs"`


Yeah that was the original implementation. I could roll it back, though this is not blocking now

jaekwon · 2018-10-16T08:45:41Z


-	if initConfig.GenTxs {
-		validators, appGenTxs, persistentPeers, err = processGenTxs(initConfig.GenTxsDir, cdc)
+	if withGenTxs {


block comment here on what withGenTxs does, namely aggregates gentxs.

jaekwon · 2018-10-16T08:46:14Z

 		}
-		var genTx server.GenesisTx
-		err = cdc.UnmarshalJSON(bz, &genTx)
+	} else {


block comment on the alternative logic, which just creates a simple genesis file with no gentxs

jaekwon · 2018-10-16T08:46:58Z


-func initWithConfig(cdc *codec.Codec, appInit server.AppInit, config *cfg.Config, initConfig server.InitConfig) (
-	chainID string, nodeID string, appMessage json.RawMessage, err error) {
+func initWithConfig(cdc *codec.Codec, appInit server.AppInit, config *cfg.Config, chainID, moniker, genTxsDir string, withGenTxs, overwriteGenesis bool) (


TODO document what this function does, including side effects like possibly creating priv validator file... etc

jaekwon · 2018-10-16T08:47:59Z

 }
+
+
+// ProcessStdTxs processes and validates application's genesis StdTxs and returns the list of validators,


s/ProcessStdTxs/CollectGenTxs/g

jaekwon · 2018-10-16T08:54:37Z

+		}
+		msg := msgs[0].(stake.MsgCreateValidator)

 		// create the genesis account, give'm few steaks and a buncha token with there name


"their name" not "there name"... some elses typo

jaekwon · 2018-10-16T08:57:11Z

+	stakeData := stake.DefaultGenesisState()
+	validator := stake.NewValidator(sdk.ValAddress(acc.Address), pubKey, stake.NewDescription(moniker, "", "", ""))
+	stakeData = addValidatorToStakeData(validator, stakeData)
+	stakeData.Pool.LooseTokens = stakeData.Pool.LooseTokens.Add(sdk.NewDecFromInt(freeFermionsAcc))


just reading the code, it looks like it's being done twice here? once in the function addValdiatorToStakeData above.

TODO: Find out how to get past genesis when using MockApp

alessio · 2018-10-18T23:43:52Z

Superseded, see #2524

alessio added the wip label Sep 29, 2018

alessio requested review from cwgoes, ebuchman and rigelrozanski as code owners September 29, 2018 15:44

cwgoes added the game-of-steaks label Oct 2, 2018

cwgoes mentioned this pull request Oct 2, 2018

SDK 0.25 / Gaia-9000 release checklist #2220

Closed

23 tasks

jaekwon self-requested a review October 8, 2018 00:09

jaekwon self-assigned this Oct 8, 2018

Alessio Treglia added 14 commits October 11, 2018 06:37

Add arg to PrintUnsignedStdTx() to actually operate in offline mode

bb999cc

Finalize gaiacli tx create-validator --genesis-format

New func processStdTxs()

3b669bd

New function to create genesis account from MsgCreateValidator

9271e03

Remove gen-tx command

6f89630

Update gaia to work with auth.StdTx

cf20953

Temporarily disable dead code

637a3c6

Fix build failures

31bfce3

Remove dead code

1c082cd

Keep on cleaning up

579007f

Cleanup, return validators as they need to be written into genesis.json

810e5bc

Cleanup, exclude node from persistent peers

9448888

Update test_helpers

7ad68fb

Experimental branch

386aa52

Modify gaiad init to allow auto-create of stdTx

93839fe

WIP

3c35642

jaekwon reviewed Oct 16, 2018

View reviewed changes

Alessio Treglia added 15 commits October 16, 2018 11:14

Fix creation of accounts

d127227

Fix coins

8d0ce68

Reintroduce gaiad testnet

a27390e

prompt user for passwords

5a656e4

Fix monikers

4b6a94e

Fix all lcd_tests

d012b35

Switch tests output back on

8ab7c77

Remove test_utils, NewTestGaiaAppGenState is now deprecated

7ccd00b

Fix all things :)

c95466b

Fix ./cmd/gaia/init tests

527b4f5

Fix tests

30e1638

Fix democoind

a40d11c

Get rid of FlagsAppGenState

a3967c4

Fix more tests

6b6b7f3

TODO: Find out how to get past genesis when using MockApp

Fix integration tests, move DefaultKeyPass into app package

4c85964

alessio force-pushed the alessio/1890-replace-genesistx-with-stdtx branch from 7360d59 to 4c85964 Compare October 17, 2018 22:19

alessio closed this Oct 18, 2018

alessio deleted the alessio/1890-replace-genesistx-with-stdtx branch October 18, 2018 23:43

		}


		// ProcessStdTxs processes and validates application's genesis StdTxs and returns the list of validators,

Conversation

alessio commented Sep 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zmanian commented Sep 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Oct 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cwgoes commented Oct 2, 2018

Uh oh!

cwgoes commented Oct 2, 2018

Uh oh!

zmanian commented Oct 3, 2018

Uh oh!

jackzampolin commented Oct 4, 2018

Uh oh!

zmanian commented Oct 6, 2018

Uh oh!

jaekwon commented Oct 8, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alessio commented Oct 18, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alessio commented Sep 29, 2018 •

edited

Loading

zmanian commented Sep 29, 2018 •

edited

Loading

codecov Bot commented Oct 1, 2018 •

edited

Loading