docs: automated local/remote testnet instructions#2271
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2271 +/- ##
===========================================
- Coverage 64.78% 63.73% -1.06%
===========================================
Files 137 140 +3
Lines 8471 8642 +171
===========================================
+ Hits 5488 5508 +20
- Misses 2620 2755 +135
- Partials 363 379 +16 |
fedekunze
left a comment
There was a problem hiding this comment.
LGTM. Left a few minor comments only
docs/getting-started/networks.md
Outdated
There was a problem hiding this comment.
I'd put this as steps outside the code square and only de bash commands with ``
There was a problem hiding this comment.
i think it's fine the way it is. Actually kinda like big code blocks like this in documentation and find there isn't enough of it
docs/getting-started/networks.md
Outdated
726fbcf to
fd1c99c
Compare
jackzampolin
left a comment
There was a problem hiding this comment.
I have some changes that should be made to the make localnet-start section. Also we need to include some CLI/RPC commands for generating transactions in the test environment/hooking up a light client to the test environment.
docs/getting-started/networks.md
Outdated
|
|
||
| The nodes bind their RPC servers to ports 26657, 26660, 26662, and 26664 on the host. | ||
| This file creates a 4-node network using the gaiadnode image. | ||
| The nodes of the network expose their P2P and RPC endpoints to the host machine on ports 26656-26657, 26659-26660, 26661-26662, and 26663-26664 respectively. |
There was a problem hiding this comment.
Maybe make this into a table?
| Node ID | P2P Port | RPC Port |
|---|---|---|
gaianode0 |
26656 |
26657 |
gaianode1 |
26659 |
26660 |
gaianode2 |
26661 |
26662 |
gaianode3 |
26663 |
26664 |
docs/getting-started/networks.md
Outdated
| make localnet-start | ||
| ``` | ||
|
|
||
| The nodes bind their RPC servers to ports 26657, 26660, 26662, and 26664 on the host. |
docs/getting-started/networks.md
Outdated
|
|
||
| ### Logging | ||
|
|
||
| Logs are saved under the attached volume, in the `gaiad.log` file and written to the screen. |
There was a problem hiding this comment.
I don't think they are written to screen anymore (-d in the docker-compose command) also the log file name shows up on my local (not container) FS as ${LOG:-gaiad.log}.
There was a problem hiding this comment.
Maybe have the sample command for tailing the logs listed here: tail -f build/node0/gaiad.log
#1932
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: