Support white fillStyle and responsible to viewport invert#436
Merged
swederik merged 1 commit intocornerstonejs:masterfrom Sep 14, 2021
laozhu:master
Merged
Support white fillStyle and responsible to viewport invert#436swederik merged 1 commit intocornerstonejs:masterfrom laozhu:master
swederik merged 1 commit intocornerstonejs:masterfrom
laozhu:master
Conversation
Member
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
fillStyleoption toEnabledElementOptions.If options.fillStyle is not set, the same with default behavior.
If options.fillStyle is set to
whiteorblack, you can set default fillStyle for different element, and the fillStyle will responsible toviewport.invert.I still have a bug here, I can't figure out it, when I have not set
renderertowebgland set thefillStyletowhite, the viewport will render to all white.🤔️ I need your help @dannyrb for finishing this PR.