Correct float access to lut array (#302)#303
Merged
swederik merged 3 commits intocornerstonejs:masterfrom Sep 13, 2021
Merged
Conversation
Contributor
Author
|
I do not have issue when I run tests |
Member
|
This makes sense. I also don't have issues running the tests. I don't know why Travis is having issues, let me restart the build to see if that changes anything. |
Member
|
Is this related to: #302 (comment) ? I'm unsure of how to action this item. Any guidance would be appreciated. |
Contributor
Author
|
Ok so i add a flag to check if slope intercept cannot be cast as integer. |
Member
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Computation of modalityLut values with float rescale slope/intercept could lead to float values.
To access to the lut array we need to get integer values other wise we will get no values