Minor tweaks

benjamin-shen · benjamin-shen · commit 348ee9611904 · 2021-10-23T21:38:54.000-04:00
diff --git a/src/store.ts b/src/store.ts
@@ -6,8 +6,8 @@ import computeGroupedRequirementFulfillmentReports from './requirements/requirem
 import RequirementFulfillmentGraph from './requirements/requirement-graph';
 import { createAppOnboardingData } from './user-data-converter';
 import {
-  getCurrentSeason,
   sortedSemesters,
+  getCurrentSeason,
   checkNotNull,
   getCurrentYear,
   allocateAllSubjectColor,
diff --git a/src/utilities.ts b/src/utilities.ts
@@ -19,7 +19,7 @@ export const sortedSemesters = (
   semesters: readonly FirestoreSemester[],
   orderByNewest = true
 ): readonly FirestoreSemester[] =>
-  [...semesters].sort((a, b) => {
+  semesters.slice().sort((a, b) => {
     // sort in increasing order iff orderByNewest is false, increasing otherwise
     const order = orderByNewest ? -1 : 1;
     const byYear = a.year - b.year;
