This PR is stale because it has been open 45 days with no activity.

@coreybutler Bump

Alright, we're going to give this a shot. There will be a new minor release sometime in the next week, so we'll see how it goes.

@coreybutler Can you rerun the failed workflow in https://github.com/coreybutler/nvm-windows/actions/runs/4685243965/jobs/8302161400?

Edit: nvm-setup.exe doesn't exist. Please add that first then rerun the workflow.

@sitiom I think the action ran before the assets were fully uploaded. nvm-setup.exe was included when I cut the release. However; it looks like the process is expecting a URL. I don't know where this would be configured or what the value should be. https://github.com/coreybutler/nvm-windows/actions/runs/4685243965/jobs/8302254488#step:2:93

@sitiom I think the action ran before the assets were fully uploaded. nvm-setup.exe was included when I cut the release.

This is the case. The action is expecting for an nvm-setup.exe asset. However, I still don't see the nvm-setup.exe asset in the releases. Was it really included?

https://github.com/coreybutler/nvm-windows/releases/tag/1.1.11

@sitiom - my mistake, I read that as nvm-setup.zip, which does exist.

Can you try to rerun the workflow again? The latest error is unusual 🤔. Maybe the token is invalid?

@russellbanks Any ideas? https://github.com/coreybutler/nvm-windows/actions/runs/4685243965/jobs/8313882263

Manually created the PR for now: microsoft/winget-pkgs#102565 (comment)

@sitiom The URL it is complaining about only exists in the README of the repo, for a "sponsor" (which happens to be one of my firms). I know the link is valid, but I'm not sure why the README would be picked up at all.

I think it took the first link from your GitHub profile as the PublisherUrl.

I think it took the first link from your GitHub profile as the PublisherUrl.

This is it, the tool that the github action uses takes the "website" field from your github profile and uses it as the publisher URL :/

https://github.com/russellbanks/Komac/blob/2d92db680c29ee43a2a6c085d8a34ec36dd736c4/src/main/kotlin/detection/github/GitHubDetection.kt#L62

Well that's annoying. Metadoc (the linked page) is one of my other ventures, unrelated to NVM4W.

Komac (the tool used by this action) now prioritises the repo homepage over the owner's website field for the publisher url, adding the repo page url (https://github.com/coreybutler/nvm-windows) to the about section might now fix this.

Any progress on this? Winget still has 1.1.10 instead of 1.1.12

Any progress on this? Winget still has 1.1.10 instead of 1.1.12

#1066 (comment)