Do not elevate unless necessary#511
Merged
coreybutler merged 1 commit intocoreybutler:masterfrom Mar 25, 2020
Merged
Conversation
This changes `elevate.cmd` to first try to execute the requested command *without* elevation. If the command failed (i.e., `ERRORLEVEL` was non-zero), then retry the command with elevation. Fixes coreybutler#510
Contributor
Author
|
I've tested that this works on Windows 10.0.18363 with Developer Mode enabled and |
nbabanov
approved these changes
Mar 24, 2020
coreybutler
approved these changes
Mar 25, 2020
Owner
coreybutler
left a comment
There was a problem hiding this comment.
This seems like a good addition to me. Thank you!
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
elevate.cmdto first try to execute the requested command without elevation. If the command failed (i.e.,ERRORLEVELwas non-zero), then retry the command with elevation.Fixes #510