Installer improvements when alt creds are required for elevation#459
Merged
coreybutler merged 4 commits intocoreybutler:masterfrom Feb 14, 2023
Merged
Conversation
Closed
Owner
|
Thanks for this, and sorry for the delayed response (I've been out of town). I should be able to review/test this next week. |
|
Is there any Update when you have time for some review? Sounds like a solution for my problems too. :) |
coreybutler
approved these changes
Feb 14, 2023
Owner
|
Better late than never. This just got buried. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing nvm-windows, if you supply alternate credentials to gain elevation, the installer will create the user environment variables under the user profile of the credentials you supplied rather then the user profile of the user who originally launched the installer. To get around this I made use of the ExecAsOriginalUser Inno Setup function. This function lets you shell execute under the original user. I was able to call REG.EXE to add %NVM_HOME% and %NVM_SYMLINK% but to handle the parsing/appending of the original path I had to create a VBScript and launch it with ExecAsOriginalUser. I actually created a setuserenv.vbs for the install and unsetuserenv.vbs for the uninstall.